Change Llama2 from the Turbine implementation to the Sharktank one #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetters-amd
commented
Sep 19, 2024
| ) | ||
| # TODO: Convert to gguf, delete cache |
There was a problem hiding this comment.
The way that sharktank recommends for generating the .gguf file is to use a CLI tool from llama.cpp. Is that still the best way to extract that, or do we have a way to do it using sharktank?
gpetters-amd
commented
Sep 19, 2024
| model = PagedLlamaModelV1(dataset.root_theta, llama_config) | ||
|
|
||
| fxb = FxProgramsBuilder(model) | ||
| self.torch_ir = export(fxb) |
There was a problem hiding this comment.
Not sure why, but this is producing an empty module. Any idea what I'm missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still two outstanding issues I'd like some comments on, but otherwise this should be basically done.